Basic open/save functionality #331
Open
+87
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
muescha
reviewed
Jul 9, 2022
| do { | ||
| try textData?.write(to: pathUrl) | ||
| } catch let error as NSError { | ||
| setText("Failed to save content to file '\(pathUrl.path)'. (Reason: \(error.localizedFailureReason!))") |
There was a problem hiding this comment.
bad move ;)
it replaces my "important" text and its deleted :/
tinyg
added a commit
to tinyg/Boop
that referenced
this pull request
Jul 23, 2023
Port nobecutan's changes to the latest version of Boop and then make the errors show in the status view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this merge request I propose basic file handling functionality. Open any file type and try to parse it as String via
String(contentsOf: pathUrl)– silently ignore the file if it cannot be parsed. This works also viaCMD+Oand by dragging the file on the app icon.This addresses #256 and #227.
Save the content as file (via
CMD+S). There is no notion of an open file, it's always "Save As…".This addresses #278.